Skip to content

Mark RedisCluster method as impure #4415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: 2.1.x
Choose a base branch
from
Open

Mark RedisCluster method as impure #4415

wants to merge 2 commits into from
+373 −0

Conversation

VincentLanglet
Copy link
Contributor

Similar to #4409

@ondrejmirtes
Copy link
Member

Would you want to add something like @phpstan-all-methods-impure and pure above classes? It'd be more maintainable than this.

It'd still be possible to exclude a method and do the opposite above it.

@VincentLanglet
Copy link
Contributor Author

Would you want to add something like @phpstan-all-methods-impure and pure above classes? It'd be more maintainable than this.

It'd still be possible to exclude a method and do the opposite above it.

Like this phpstan/phpdoc-parser#277 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VincentLanglet @ondrejmirtes